Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

branch: 1.1-phetio

Open
#140 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
git
Domain
release

Research direction

Start by reviewing the 1.1-phetio branch and the git history for the listed 1.1 versions, then compare those records with the bayes directory listing. Determine why the branch and versions exist, whether clients or the PhET-iO spreadsheet depend on them, and document the unexplained version and commit discrepancies.

Written by the indexing model from the issue text.

Description

In https://github.com/phetsims/function-builder/issues/139, I was attempting to publish a new version of Function Builder. The published version is 1.0.x, so I was expecting to be publishing 1.1.x. But when I went to publish the dev version of Function Builder, it was 1.2.x. Investigation revealed a 1.1-phetio branch and many 1.1 versions published to bayes. That resulted in a lot of confusion and a significant detour.

It looks like @samreid, @zepumph, and @jonathanolson were involved in this. As the responsible dev for this repo, please help me understand (or remember) what is going on here.

There is no 1.1 branch, but there is a 1.1-phetio branch. I'm not sure who created it.

function-builder has no PhET-iO instrumentation, and brand=phet is not enabled in package.json.

Here are the 1.1 versions on bayes, annotated with who published them (according to git history):

% ls -ltd 1.1.*
drwxrwsr-x+ 2 tomcat     phet 118 Jun  5  2017 1.1.0-dev.4/ => ??
drwxrwsr-x+ 2 tomcat     phet 102 May 17  2017 1.1.0-dev.3/ => ??
drwxrwxr-x+ 5 tomcat     phet 133 Nov 12  2016 1.1.2-phetiophetio/ => @samreid 
drwxrwxr-x+ 5 tomcat     phet 134 Oct  5  2016 1.1.1-phetio/ => @zepumph 
drwxrwxr-x+ 6 tomcat     phet 151 Sep 30  2016 1.1.0-phetio/ => @zepumph 
drwxrwsr-x+ 5 tomcat     phet 207 Sep 28  2016 1.1.0-phetio.4/ => @mattpen
drwxrwxr-x+ 4 tomcat     phet 118 Sep 24  2016 1.1.0-phetiodev.3/ => @samreid 
drwxrwsr-x+ 3 tomcat     phet 137 Aug 29  2016 1.1.0-dev.2/ => @samreid 
drwxrwsr-x+ 3 tomcat     phet 137 Aug 23  2016 1.1.0-dev.1/ => @samreid 

Questions:

  • Why was this branch created? What PhET-iO work was involved?

  • Are any of these versions used by clients, being maintained, in the PhET-iO spreadsheet, etc?

  • If these versions were published from 1.1-phetio, why is the syntax for these version numbers all over the place? And I'm not clear on how we got version numbers with "1.1.x-dev.x" syntax when there is no 1.1 branch.

  • 1.1.0-dev.3/ and 1.1.0-dev.4 have no associated commits. How could that be?

  • I see git history for these 1.1 versions that do not appear on bayes. How could that be?

1.1.3-rc.2 => @zepumph 6/28/18
1.1.3-phetiorc.2 => @zepumph 6/28/18
1.1.3-rc.4 => @jonathanolson 6/29/18
1.1.3-rc.5 => @jonathanolson 7/6/18

Dominant language
TypeScript
Stars
5
Forks
6
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phetsims/function-builder

All issues in phetsims/function-builder

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.