Document the distribution of `Phaser.Math.RND.weightedPick` inside its JSDoc

Open Beginner friendly
#7,300 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript
Domain
documentation

Research direction

Locate the JavaScript definition of Phaser.Math.RND.weightedPick and read its existing JSDoc alongside the shown selection formula. Update the JSDoc to explain precisely how the formula favors earlier array items, including the relevant distribution detail; done means the documented behavior matches the implementation.

Written by the indexing model from the issue text.

Description

Currently, the weightedPick function fails to mention precisely how much earlier items in the array are favored over later ones, which is a fairly important detail to simply omit without mention.

Admittedly, the provided code isn't the clearest in the world either...

    weightedPick: function (array)
    {
        return array[~~(Math.pow(this.frac(), 2) * (array.length - 0.5) + 0.5)];
    },
Dominant language
JavaScript
Stars
40.3k
Forks
7.2k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phaserjs/phaser

All issues in phaserjs/phaser

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.