Have HTTP 4xx instead of 5xx on SQL syntax error
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
The payload names no source files, so start by reproducing: run a query with a SQL syntax error in the pgAdmin Query Tool and note the HTTP status returned (500) and the JSON body. Then find where the server converts PostgreSQL errors into HTTP responses, and check how the linked upstream issue #9872 handled similar errors. Done means a syntax error returns a 4xx status such as 400 with the same JSON body, and other server errors keep their current status.
Written by the indexing model from the issue text.
Description
Describe the solution you'd like
Hi,
I create this ticket to follow https://github.com/pgadmin-org/pgadmin4/issues/9872, I'm in case of a corporate IT infra where proxy security cannot be changed and this last replace JSON body response for request whose response code is HTTP 5xx by a proxy specific response.
The security reason is to avoid potentiel technical leak from backend.
In addition in a Rest API design, it is not semantically correct to have a HTTP 500 when pgadmin user enter an incorrect SQL request, a HTTP 400 Bad Request should be more appropriate.
Describe alternatives you've considered
The alternative should be to have pgadmin server answer HTTP 400 Bad Request code and pgadmin webapp interpret JSON as before.
- Dominant language
- Python
- Stars
- 3.9k
- Forks
- 922
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 33
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pgadmin-org/pgadmin4
-
Invalid syntax in sshtunnelPossibly taken A pull request linked to this issue is open or already merged. OpenBug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
pgadmin-org/pgadmin4#10797 ·
Maintainers usually reply within 2 days
-
Feature
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pgadmin-org/pgadmin4#10426 · 3 comments · 1 reaction ·
Maintainers usually reply within 2 days
-
Bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
pgadmin-org/pgadmin4#10796 · 1 comment ·
Maintainers usually reply within 2 days
-
Schema Diff does not detect foreign keys that reference a different schemaPossibly taken @dpage claimed this today. Open
Difficulty 4/5 3-5 days Newbie friendliness 57/100
pgadmin-org/pgadmin4#10786 · 1 assignee ·
Maintainers usually reply within 2 days
-
Bug
Difficulty 4/5 3-5 days Newbie friendliness 55/100
pgadmin-org/pgadmin4#10783 ·
Maintainers usually reply within 2 days
All issues in pgadmin-org/pgadmin4
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mohanraj00/entelos#200 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
sweep
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
bketelsen/truenas-mcp#77 ·
Maintainers usually reply within 1 day
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
openedx/xblock-lti-consumer#765 ·
Maintainers usually reply within 1 day