plan cluster add crashes when a finding has a protected skip

Open Beginner friendly
  • Is something wrong?
#930 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
cli

Research direction

Start at _cmd_cluster_add and trace how it calls save_plan and reaches validate_plan; then look for tests covering plan cluster add and protected skips. Run the relevant CLI tests and add coverage for the reproduction. Done means the command gives a clear refusal pointing to plan unskip --force without crashing or overriding the protected skip.

Written by the indexing model from the issue text.

Description

Adding a permanently skipped finding to a manual cluster exits with an uncaught validation traceback instead of explaining that the skip must be removed first.

Observed against commit 5ec6be635834a6f424cd4a5f4321931f28b4a567 on macOS / Python 3.14. The repository also contains local scanner corrections outside the affected cluster-add path.

Reproduction with any existing finding ID:

desloppify plan skip --permanent '<finding-id>' --note 'Specific disposition' --attest 'I have reviewed this issue and I am not gaming the score.'
desloppify plan cluster create example
desloppify plan cluster add example '<finding-id>'

Actual: _cmd_cluster_add calls save_plan, which calls validate_plan, raising:

ValueError: IDs cannot appear in both queue_order and skipped: ['<finding-id>']

Expected: a normal CLI refusal explaining the protected skip and pointing to plan unskip --force, or explicitly supported behavior for skipped cluster membership without placing it in the active queue. The command should not crash or implicitly override a protected skip.

Workaround verified: run plan unskip --force '<finding-id>' when reopening is warranted, then repeat plan cluster add. A plain plan unskip preserves protected skips and returns exit 0, so blindly chaining it with cluster-add still triggers the traceback.

Dominant language
Python
Stars
3.8k
Forks
301
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from peteromallet/desloppify

All issues in peteromallet/desloppify

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.