[Trino] Add datasource health check via GET /v1/info

Open Beginner friendly
#935 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
api, backend

Research direction

Start by finding TrinoDatasource and its existing request and proxy configuration, then check how other datasources implement healthCheck. Add the /v1/info request and allow that endpoint through the default proxy; report failure when the request fails or the response says starting is true. Done when the datasource editor can use this check and the relevant tests cover both failure conditions.

Written by the indexing model from the issue text.

Description

enhancement

Follow-up from the review of #931.

The Trino datasource has no healthCheck, so the datasource editor can't tell the user whether the URL, proxy and credentials work. Trino's GET /v1/info is a cheap endpoint for this: it returns the server version and starting state without running a query.

Proposal: implement healthCheck in TrinoDatasource using GET /v1/info, and add GET /v1/info to the default proxy allowedEndpoints. Report a failure when the request fails or starting is true.

Dominant language
TypeScript
Stars
33
Forks
95
Avg merge
2d 12h
Merged PRs (30d)
40

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from perses/plugins

All issues in perses/plugins

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.