[Bug] detect: elements inside an `inert` subtree under a page overlay count as occluded/nested content
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- html, javascript
- Domain
- accessibility, frontend
Research direction
Start with the browser detector and reproduce the issue using the minimal HTML example in the report. Check how it handles closed <details> content, as noted in #882, and compare that with elements under inert. Done means the detector skips inert content so it no longer triggers text-occlusion or nested-cards.
Written by the indexing model from the issue text.
Description
Summary
The browser detector counts elements inside an inert subtree, that sits under an absolutely positioned page overlay, as live page content. text-occlusion and nested-cards then fire on content the user cannot see or reach. This is the same family as #882 (closed <details> content counted as an occluder), but for inert.
Where I hit it
I ran /impeccable critique against the Fleet page of an Electron app (wmux). The scanner was injected into the renderer through CDP, which works fine; see the separate issue about desktop apps.
- The Fleet page is a route overlay:
.wmux-page { position: absolute; z-index: 40 }. - The workspace view stays mounted underneath, inside an ancestor with the
inertattribute.
The scan reported:
text-occlusion×27. Every hit pointed at the inert sidebar under the overlay. The overlay's own rows hit-test to themselves.nested-cardsandcramped-paddingalso fired on the inert sidebar and a pane header under the overlay.
So 30+ of the 35 findings on that page were noise. The real ones (three low-contrast hits and a skipped heading level) were easy to miss among them.
Repro (minimal)
<body>
<div inert>
<aside style="width:260px;border:1px solid #ddd;border-radius:8px;padding:8px">
<div style="border:1px solid #ddd;border-radius:8px;padding:8px">Workspace A</div>
<span>Status text that is fully covered</span>
</aside>
</div>
<main style="position:absolute;inset:0;z-index:40;background:#fff">Overlay page</main>
</body>
Run the browser detector: the covered, inert text is reported.
Expected
Skip elements inside an inert subtree, the same way #918 skips closed <details> content. More generally, skip anything that is not hit-testable at rest (also covers aria-hidden route stacks and visibility:hidden keep-alive views).
Environment
impeccable skill 4.5.0, CLI 4.0.0 (darwin-arm64), detector injected via impeccable live-server into an Electron 146 renderer.
Prepared with AI assistance (Claude Code); reviewed and posted by the account owner.
- Dominant language
- Rust
- Stars
- 111k
- Forks
- 6.7k
- Avg merge
- 20h 3m
- Merged PRs (30d)
- 344
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pbakaus/impeccable
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
pbakaus/impeccable#1653 ·
Maintainers usually reply within 1 day
-
detect: rendered scan follows the host's colour scheme instead of lightPossibly taken @abdulwahabone claimed this 2 days ago. Openneeds triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
pbakaus/impeccable#1620 · 1 assignee ·
Maintainers usually reply within 1 day
-
[Bug] `doctor` still reports `design-md-sprawl` after successful compactionPossibly taken A pull request linked to this issue is open or already merged. Openneeds triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pbakaus/impeccable#1601 ·
Maintainers usually reply within 1 day
-
[Bug] critique-storage writes the snapshot under the cwd, not the target's projectRootPossibly taken @abdulwahabone claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pbakaus/impeccable#1598 · 1 assignee ·
Maintainers usually reply within 1 day
-
enhancement needs triage
Difficulty 1/5 Under an hour Newbie friendliness 88/100
pbakaus/impeccable#1573 ·
Maintainers usually reply within 1 day
All issues in pbakaus/impeccable
Similar issues
-
ui: Rail items do not show a pointing-hand cursor on hoverPossibly taken @yoriswind claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
storytold/craft-libs#3062 · 1 comment ·
Maintainers usually reply within 1 day
-
文件夹重大BUG:不支持重命名Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CCExtractor/ccextractor#2478 ·
Maintainers usually reply within 7 days
-
postgresql-rules / queue-rules: implicit KEY SHARE before a parent key update, and job self-overlapOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jonathanong/no-mistakes#3879 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day