richtext-lexical: CodeBlock markdown import prepends "undefined" and truncates info strings
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- node.js, typescript
Research direction
Read packages/richtext-lexical/src/features/blocks/premade/CodeBlock/converter.ts and the reproducing spec at packages/richtext-lexical/src/features/blocks/premade/CodeBlock/converter.spec.ts. Run the unit command from the issue to see the failing import and export cases. Done means all 20 cases pass, including empty language and info strings such as c++; an open linked pull request already addresses this issue.
Written by the indexing model from the issue text.
Description
Describe the Bug
The premade CodeBlock markdown converter (packages/richtext-lexical/src/features/blocks/premade/CodeBlock/converter.ts) corrupts code in two ways, through both convertMarkdownToLexical and convertLexicalToMarkdown.
- A one-line fence whose code starts with a non-word character imports with
undefinedin front of the code.```$ ls```gives codeundefined$ ls. Blocks with an empty language export to this one-line form, so they are corrupted on a round trip as well:{ language: '', code: '$ npm i -g x' }comes back asundefined$ npm i -g x, and an empty block comes back asundefined. - An info string with characters outside
\wis cut at the first such character, and the rest ends up in the code.```c++gives languagecand code++\n…. The same happens forc#,objective-candshell-session.
The file is identical on main and 3.x.
Link to the code that reproduces this issue
https://github.com/anatolykoptev/payload/commit/7e8d837e04 (a unit spec only, with no fix, on top of main 56033d9561)
Reproduction Steps
- Check out the linked commit and run
pnpm install. - Run
pnpm vitest run --project unit packages/richtext-lexical/src/features/blocks/premade/CodeBlock/converter.spec.ts. - 11 of 20 cases fail. Examples:
expected 'undefined$ ls' to be '$ ls',expected 'undefined' to be '', and forc++the code is'++\nint x;'instead of'int x;'. The controls pass (a multi-line fence with a language,```foo```, a bare multi-line fence).
Which area(s) are affected?
plugin: richtext-lexical
Environment Info
@payloadcms/richtext-lexical 4.0.0-beta.9 (main at 56033d9561); same code in 3.93.0 / 3.x
Node v22.22.3 (where the spec was run)
- Dominant language
- TypeScript
- Stars
- 45.8k
- Forks
- 4.4k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 251
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from payloadcms/payload
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Document bar (.doc-controls__content) overflows a 375 px viewport, clips "Created" and fails axe scrollable-region-focusablePossibly taken A pull request linked to this issue is open or already merged. Openarea: ui Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
payloadcms/payload#19690 ·
Maintainers usually reply within 1 day
-
[v4] Blocks thumbnails croped 3:2Possibly taken @samiarif02 claimed this 2 days ago. Openarea: ui Bug Payload OSS status: needs-triage v3
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
payloadcms/payload#19609 ·
Maintainers usually reply within 1 day
-
Scheduled publish jobs are not deleted when their document is deleted (string id in the job, raw id in the cleanup)Possibly taken @volodymyrshk claimed this 10 days ago. Openarea: core Bug db: sqlite
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19448 ·
Maintainers usually reply within 1 day
-
plugin-multi-tenant: `isGlobal` collections redirect tenant-scoped users to `/admin` since 3.93.0 (GlobalViewRedirect prop-name mismatch)Possibly taken @JarrodMFlesch claimed this 10 days ago. OpenBug plugin: multi-tenant
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19420 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in payloadcms/payload
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
milind-soni/OpenMausBot#6730 ·
Maintainers usually reply within 1 day
-
`@angular/[email protected]` depends on vulnerable Vite 7.3.7 - GHSA-p4f5-76q4-ffq7 (Critical RCE)Openarea: @angular/build
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
angular/angular-cli#34764 ·
Maintainers usually reply within 1 day
-
status/need-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google-gemini/gemini-cli#30384 · 1 comment ·
Maintainers usually reply within 1 day
-
P2
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
area:image documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day