Potential solution for Dragonflight Changes to Milling/Prospecting/Unraveling
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
Research direction
The payload names no addon source files, so start by finding the existing mill, prospect and unravel code in the addon. The reporter's working macro scans bag slots with ItemLocation:CreateFromBagAndSlot and calls C_TradeSkillUI.CraftSalvage(395696, 500, lnk) on a Mystic Sapphire stack (item 192841). Confirm those IDs still apply to the current expansion before reusing them. Done means the addon performs the salvage craft through the API without the macro. The issue is over 1,200 days old with no assignee and one comment, so ask the maintainer whether the approach is still wanted first.
Written by the indexing model from the issue text.
Description
Hey there. You mentioned in your addon description that if a way to programmatically Mill/Prospect/Unravel was found, you might be able to update to work with the new Dragonflight profession systems.
Well, I have a macro template that can do it, and maybe you can incorporate the method into the addon.
Here's a macro that finds a stack of Mystic Sapphire rank 2s in my bags, and then performs a repeated Crushing attempt on that stack.
/run for bg=0,5 do for s=1,C_Container.GetContainerNumSlots(bg) do local lnk=ItemLocation:CreateFromBagAndSlot(bg,s) if lnk:IsValid() and C_Item.GetItemID(lnk) == 192841 then C_TradeSkillUI.CraftSalvage(395696,500,lnk) return end end end
Same macro, just spaced out some:
/run for bg=0,5 do
for s=1,C_Container.GetContainerNumSlots(bg) do
local lnk=ItemLocation:CreateFromBagAndSlot(bg,s)
if lnk:IsValid() and C_Item.GetItemID(lnk) == 192841 then
C_TradeSkillUI.CraftSalvage(395696,500,lnk)
return
end
end
end
The "C_Item.GetItemID(lnk) == 192841" part is what defines it as Mystic Sapphire rank 2, and the
profession call is C_TradeSkillUI.CraftSalvage(395696,500,lnk), with 395696 being the spell id for crushing, 500 being the number of times to do it, and the lnk being the variable holding the stack found earlier.
I have other macros that do unraveling and prospecting with the same method. not sure how cleanly you can translate the macro acceptable code to an addon, but I figured I'd send it to you and see if it helps.
- Dominant language
- Lua
- Stars
- 3
- Forks
- 0
- Avg merge
- 3h 8m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
orbitalquark/scintillua#223 ·
-
bug code-annotation
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
quarto-dev/quarto-cli#15215 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
RLS-Modding/rls_career_overhaul#511 · 1 reaction ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
P-47D: GEAR_LVR always reads 1Possibly taken @cbass2404 claimed this 1 day ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
DCS-Skunkworks/dcs-bios#1932 ·