Mobile signing prompts do not show whose account is being used
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- mobile-dev
Research direction
Start with TrUAPIReviewPromptMapper.swift and ConfirmationReviewMapping.kt, then compare their handling of callingProductId with the host-cli rendering. Trace the signing review payloads into TrUAPIConfirmation.Signing and StatementSignConfirmationRequest. Done means iOS and Android show both caller and owner, and identify when the products differ.
Written by the indexing model from the issue text.
Description
A product granted context can sign with another product's account (#873). The user confirming that signature is meant to see both names. On iOS and Android they see one.
- iOS
TrUAPIReviewPromptMapper.makeStatementSignRequesttakes the requester fromreview.account.dotNsIdentifier, which is the account owner, not the caller. A cross-product statement sign names the wrong product. - Android
ConfirmationReviewMappingtakes the caller from the connection and never shows the owner. - Both ignore the
callingProductIdthat #873 added toSignPayloadReview,SignRawReview,CreateTransactionReviewandStatementStoreProductSignReview.
The host-cli renders both, so the behaviour is specified and only the two signing hosts are missing it.
Fix
Carry the owner alongside the caller into TrUAPIConfirmation.Signing and StatementSignConfirmationRequest, and say in the sheet when they differ.
hosts/ios/polkadot-app/Modules/Products/TrUAPI/Confirmation/TrUAPIReviewPromptMapper.swifthosts/android/feature/products/impl/src/main/java/io/paritytech/polkadotapp/feature_products_impl/domain/truapi/ConfirmationReviewMapping.kt
- Dominant language
- Swift
- Stars
- 10
- Forks
- 3
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 211
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from paritytech/host-rust-core
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
paritytech/host-rust-core#868 ·
Maintainers usually reply within 1 day
-
Suggestion: Index Usernames from chain locally to speed up contacts searchPossibly taken @duewarn claimed this today. Open
paritytech/host-rust-core#1092 · 1 assignee ·
Maintainers usually reply within 1 day
-
Android. Coinage - Funds Send RecallPossibly taken @mikyar claimed this today. Open
paritytech/host-rust-core#1091 · 1 assignee ·
Maintainers usually reply within 1 day
-
iOS. Coinage - Funds Send RecallPossibly taken @sergkononenko claimed this today. Open
paritytech/host-rust-core#1090 · 1 assignee ·
Maintainers usually reply within 1 day
-
Coinage. Funds Send RecallPossibly taken @sergkononenko claimed this today. Open
paritytech/host-rust-core#1088 · 3 assignees ·
Maintainers usually reply within 1 day
All issues in paritytech/host-rust-core
Similar issues
-
area: agents area: cli bug difficulty:2 help wanted S3: minor
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
manaflow-ai/cmux#15718 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mozilla-mobile/firefox-ios#35850 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
chattymin/PokeTokenBar#385 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
appandflow/stim#1941 ·
Maintainers usually reply within 1 day
-
product / avatars product / self-hosted product / storage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
appwrite/appwrite#13985 · 1 comment ·
Maintainers usually reply within 1 day