Some bundled smooth art has no @2x version and looks soft at 1.5x and 2x

Open
#797 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
lua

Research direction

Start by locating the listed panels/__default assets, the Modern default stage background.png, and the named [email protected] sheets; check how the game loads and scales these images. Add the suggested higher-resolution versions at twice their drawn dimensions, then verify they appear sharp at 1.5x and 2x window sizes.

Written by the indexing model from the issue text.

Description

Some bundled art that isn't pixel art has only one image pixel per canvas pixel. In a window larger than 1280x720, such as 1920x1080 (1.5x) or 2560x1440 (2x), the game enlarges it and it looks softer than art that has a high-resolution @2x version.

Affected art

Art File size Drawn at Image pixels per canvas pixel
Panel Attack Classic panels (panels/__default): 57 panel images, garbage flash, 3 metal pieces 48x48, metals 24x48 same as file size 1
Panel Attack Modern default stage background.png 1280x720 1280x720 1
[email protected] for __default, Esme, Madam Q, Magellan and Rattles 96x96 per frame 96x96 per frame 1

The fade sheets are named @2x, but fade is drawn at 96x96 per frame (two panels), so they are 1x for what they draw. They need 192x192 frames to be sharp at 2x.

Already fine

  • The Modern combo and chain cards: 96x96 files drawn at 48x48.
  • The default telegraph images: 144x96 files drawn at 72x48.
  • Pixel art that is half its drawn size or smaller: it uses nearest filtering and stays crisp at any size.

Suggested fix
Add @2x versions at twice the drawn size: 96x96 panels and garbage flash, 48x96 metal pieces, a 2560x1440 background, and 192x192 fade frames.

Found while working on #768.

Dominant language
Lua
Stars
30
Forks
20
Avg merge
3d 15h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from panel-attack/panel-game

All issues in panel-attack/panel-game

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.