Challenge Mode doesn't shutdown properly when you win
Maintainers usually reply within 3 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
Research direction
Start in client/src/scenes/ChallengeModeRecapScene.lua at line 44, where the recap pops the navigation stack, and compare the win path with the cleanup used on a loss. Check how the challenge battle room is shut down, then verify that winning shuts it down and that the menus work properly afterward.
Written by the indexing model from the issue text.
Description
The recap leaves with GAME.navigationStack:popToTop() (client/src/scenes/ChallengeModeRecapScene.lua:44) and never shuts the challenge's battle room down.
This causes some menus to not work properly.
Probably just need to cleanup on win just like we do on lose.
- Dominant language
- Lua
- Stars
- 30
- Forks
- 20
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from panel-attack/panel-game
-
engine priority: 3 - wishlist wontfix
Difficulty 1/5 Under an hour Newbie friendliness 90/100
panel-attack/panel-game#780 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
panel-attack/panel-game#779 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
panel-attack/panel-game#776 ·
Maintainers usually reply within 3 days
-
Anonymous replays leak the player 2's real publicId, winnerId names the wrong player whenever player 1 winsPossibly taken @JamesVanBoxtel claimed this 4 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
panel-attack/panel-game#766 ·
Maintainers usually reply within 3 days
-
bug
Difficulty 3/5 Half a day Newbie friendliness 25/100
panel-attack/panel-game#791 ·
Maintainers usually reply within 3 days
All issues in panel-attack/panel-game
Similar issues
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
scp-fs2open/fs2open.github.com#7914 ·
Maintainers usually reply within 1 day
-
severity: low
Difficulty 1/5 1-3 hours Newbie friendliness 89/100
luainkernel/lunatik#1980 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
petertriho/nvim-scrollbar#120 ·