Replay not saving LevelData under certain conditions

Open
#662 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
lua
Domain
game-dev

Research direction

Start by examining the older crash log and tracing how replay LevelData is saved and loaded, including the server-transmitted data and the replay stack's LevelData setter mentioned in the issue. Try to identify the conditions that leave LevelData unsaved and cause replay loading to crash; done means the failure is reproducible and the underlying cause is confirmed.

Written by the indexing model from the issue text.

Description

bug Client-side needs repro priority: 2 - low

Musichael played a bunch of games both online and offline

A bit of both—online + occassional 1p vs self/endless/time attack here and there
I do recall spectating more sets than playing if that helps

crash.log
crash(1).log
(the second is the older and likely more helpful one)

After a certain moment level data no longer got saved in replays which led to replays crashing on load.

Haven't really been able to figure out how this happens so far.
This might be owed to "excessively" validating data that is set to a replay stack's levelData property so that a setter fails somehow sometime due to leveldata transmitted from the server side not getting the correct metatable assigned.

Dominant language
Lua
Stars
30
Forks
20
Avg merge
3d 15h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from panel-attack/panel-game

All issues in panel-attack/panel-game

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.