Verify consistent leave behaviour
Maintainers usually reply within 1 day
@Endaris is already working on this.
Since Jun 20, 2025.
Assessment
This issue has not been assessed yet.
Description
Marking this so I don't forget:
On 5th May, Lava had a very weird crash related to unpacking inputs:
Both players were on controller so evidently the crash is unrelated to #628 although otherwise it looks similar.
One thing that is noteworthy is that prior to the final spectate, Lava leaves a previous room from spectating and sends a leaveRoom message twice with quite the delay inbetween which could be related.
Another guess is that the replay compression is not handled properly here on either client or server side or even both:
As evident in the spectator join message, the inputs of player 1 are not compressed, yet the inputs of player 2 are.
As the crash occurs in GameCatchup it seems like another possibility that player 2 never had their inputs decompressed and successively crashed at trying to interpret the first character that is not part of the encoding's character set: (.
So verify that and if not the case correct that:
- Server always compresses inputs in outgoing replays
- Client always decompresses in incoming replays
- NetClient checks calls to its leaveRoom function with its state to decide whether a message is sent to the server or not.
I don't really have a good idea to force a repro for this issue but I think with these steps it's quite likely for the problem to disappear.
- Dominant language
- Lua
- Stars
- 30
- Forks
- 20
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 17
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from panel-attack/panel-game
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
panel-attack/panel-game#822 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
panel-attack/panel-game#779 ·
Maintainers usually reply within 1 day
-
bug Client-side priority: 0 - high
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
panel-attack/panel-game#776 ·
Maintainers usually reply within 1 day
-
enhancement priority: 1 - middle
Difficulty 4/5 3-5 days Newbie friendliness 48/100
panel-attack/panel-game#821 ·
Maintainers usually reply within 1 day
-
Animation scenes draw every part separately, costing hundreds of draw calls a framePossibly taken @JamesVanBoxtel claimed this 4 days ago. OpenClient-side enhancement graphics
panel-attack/panel-game#814 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in panel-attack/panel-game
Similar issues
-
slice weekend
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
Life-Framework/Life-Framework#3212 ·
Maintainers usually reply within 1 day
-
bug discord guide:01b-riverglades locale:enUS triage v4.1.1
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
petertriho/nvim-scrollbar#127 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100