Add more fanfares for bigger chains

Open
#525 0 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
lua
Domain
game-dev

Research direction

First read how themes define fanfares and how the per-chain system handles character chain SFX. The issue leaves two approaches open: fixed cutoffs for additional fanfares or user-configurable fanfares. Done means choosing an approach and supporting fanfares for bigger chains; no files or tests are named in the issue.

Written by the indexing model from the issue text.

Description

Client-side enhancement priority: 3 - wishlist sound

Add more fanfares to themes with new chain cutoffs.
We can either define where these are, e.g. fanfare 4 starting at x8 and fanfare 5 at x12.
Or make them custom and let users add as many fanfares as they want, similar to the approach for character's chain SFX in the per chain system.

Dominant language
Lua
Stars
30
Forks
20
Avg merge
3d 15h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from panel-attack/panel-game

All issues in panel-attack/panel-game

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.