sled-diagnostics assumes all sleds have 10 U.2s, which could be misleading when they don't
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
Research direction
Start at sled-diagnostics/src/queries.rs, lines 310-342, where the shell snippets in sled_diagnostics::queries hardcode an expected count of 10 U.2s and print WARN on smaller sleds. Read how these query strings are assembled and consumed by support bundle collection to decide what the check should become (informational, configurable, or dropped). Done means sleds with fewer than 10 U.2s no longer emit a misleading WARN while genuinely unexpected drive counts are still surfaced, and any sled-diagnostics tests still pass.
Written by the indexing model from the issue text.
Description
Some of the little shell snippets in sled_diagnostics::queries assume that the sled has 10 U.2s, and print WARN: if it is discovered to have fewer than that:
https://github.com/oxidecomputer/omicron/blob/05034a3597a34ef6c5fd1e98a784a40e1d96bfb0/sled-diagnostics/src/queries.rs#L310-L319
We are now selling sleds with fewer than 10 U.2s in them as a supported configuration, so this will always print WARN on such sleds. Luckily, these commands are used in support bundle collection, and the WARNings are generally most likely to be seen by Oxide support, who hopefully are aware of the expected number of drives in the customer's configuration, but it may still be misleading to encounter WARNings for something that may be expected?
- Dominant language
- Rust
- Stars
- 610
- Forks
- 104
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 117
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/omicron
-
development Testing & Analysis
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oxidecomputer/omicron#11582 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oxidecomputer/omicron#11397 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oxidecomputer/omicron#11390 ·
Maintainers usually reply within 1 day
-
non-important non-blocker Testing & Analysis
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
oxidecomputer/omicron#11374 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
oxidecomputer/omicron#11269 ·
Maintainers usually reply within 1 day
All issues in oxidecomputer/omicron
Similar issues
-
area/tools bug session-analysis
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
nix-community/fenix#262 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
GabrieleLozupone/kokon#41 ·
Maintainers usually reply within 1 day
-
Small glitchOpenpriority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
storytold/photocraft#9538 ·
Maintainers usually reply within 1 day
-
bug P2 rust
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day