specifying unknown build-image -F feature should lead to failure

Open Beginner friendly
#254 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
build-system, cli

Research direction

Start at the build-image entry point and trace handling of the -F feature option. Check where feature names are validated, then exercise an unknown value such as dmar and confirm that the build fails instead of succeeding.

Written by the indexing model from the issue text.

Description

I recently did a build where I specified -F dmar instead of -F mbist. The build happily succeeded; however, it'd be nice if it had failed so I had discovered this at build time and not much later.

Dominant language
Rust
Stars
481
Forks
21
Avg merge
1d 17h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/helios

All issues in oxidecomputer/helios

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.