Use JSON syntax aware approach for defining manufacturing images

Open
#231 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
build-system

Research direction

The issue proposes replacing textual patch files with a JSON syntax-aware, mk_rom_config()-style approach for defining manufacturing images. Start by locating the manufacturing image definitions and the existing mk_rom_config() implementation; done would require an agreed scope and validation that the image definitions work through the new approach.

Written by the indexing model from the issue text.

Description

I think it might have been better to use the JSON syntax aware mk_rom_config()-style approach for this, rather than textual patch files -- but we need to get moving so we'll use it as-is for now. Thanks!

Originally posted by @jclulow in https://github.com/oxidecomputer/helios/pull/230#pullrequestreview-3424925918

Dominant language
Rust
Stars
481
Forks
21
Avg merge
1d 17h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/helios

All issues in oxidecomputer/helios

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.