Likely race in Combobox enter handling
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- playwright, typescript
- Domain
- frontend, testing-qa
Research direction
Start with app/ui/lib/Combobox.tsx at lines 215-225 and inspect the Playwright CI behavior that exposes the enter-key race. Confirm how the event behaves when the list is open versus closed, including bubbling into form submission. Done means the CI race is addressed without preventing the closed-list event from bubbling and triggering submission.
Written by the indexing model from the issue text.
Description
There is probably a race in Headless's handling of the enter keypress in the combobox. This is low-priority because human users can't interact fast enough to hit the race — we only see it in CI because of Playwright.
Claude's proposed solution doesn't work because we actually need that event to bubble and be turned by Headless into a form submission when the combobox list is closed. We are reworking this form at some point, which will probably eliminate the immediate problem, but if there's a bug inside Combobox we're just kicking the can if we don't fix it.
Originally posted by @david-crespo in https://github.com/oxidecomputer/console/issues/2941#issuecomment-3444061630
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 8h 59m
- Merged PRs (30d)
- 21
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/console
-
Disks: Disable 'Size' field when selecting 'Make disk read-only' and 'Image'/'Snapshot' as a sourcePossibly taken @david-crespo claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
oxidecomputer/console#3391 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Alerting > Receivers: Error message for subscriptions gets hidden by empty dropdown when zoomed outOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
oxidecomputer/console#3390 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 72/100
oxidecomputer/console#3375 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
oxidecomputer/console#3338 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
oxidecomputer/console#3327 · 2 comments ·
Maintainers usually reply within 1 day
All issues in oxidecomputer/console
Similar issues
-
keytrace logo svg?Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
cyclofinance/cyclo.site#448 ·
-
[sanity-plugin-media] Searching for a word with an apostrophe shows an error instead of resultsOpen@sanity-io/studio bug sanity-plugin-media Sieve-Agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
pingdotgg/t3code#15221 · 1 comment ·
Maintainers usually reply within 1 day