Absent instrumentation tags in WriteLocalVariableNode and Python call nodes with one to four arguments.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 50/100
Research direction
Start by reading com.oracle.graal.python.nodes.frame.WriteLocalVariableNode and the four nested call-node classes in com.oracle.graal.python.nodes.call.PythonCallNode, then compare nearby hasTag implementations. Done means each named class provides the appropriate instrumentation tags and the existing instrumentation behavior remains valid.
Written by the indexing model from the issue text.
Description
The com.oracle.graal.python.nodes.frame.WriteLocalVariableNode class does not override the hasTag method which provides the corresponding instrumentation tags. Same issue with the four nested classes: PythonCallUnary, PythonCallBinary, PythonCallTernary and PythonCallQuaternary of the com.oracle.graal.python.nodes.call.PythonCallNode class.
I will be opening a pull request with proposed fixes.
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 155
- Avg merge
- 8h 58m
- Merged PRs (30d)
- 39
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oracle/graalpython
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
oracle/graalpython#1105 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oracle/graalpython#1102 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
oracle/graalpython#1157 · 1 assignee ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 74/100
oracle/graalpython#1133 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 68/100
oracle/graalpython#1112 ·
All issues in oracle/graalpython
Similar issues
-
Add: hunch Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
AbdelStark/awesome-typesafe#104 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/dodal#2211 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
openml/openml-python#1749 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sipyourdrink-ltd/bernstein#6191 ·