pytest might escape virtualenv in invoke

Open
#27 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start in the Invoke task that calls pytest and inspect how the command is assembled when a virtualenv is not activated. Verify the task invokes pytest through the active Python interpreter, then run the available project tests to confirm the virtualenv is respected.

Written by the indexing model from the issue text.

Description

enhancement

@rgaudin said:

Found an issue: by calling pytest directly in invoke, it might escape a virtualenv if it's not activated (env/bin/inv coverage).
Can be fixed with:

    pyexe = shlex.quote(sys.executable)
    ctx.run(f"{pyexe} -m pytest {args}", pty=use_pty)
Dominant language
Python
Stars
1
Forks
2
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openzim/_python-bootstrap

All issues in openzim/_python-bootstrap

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.