Add Magnet dialog retains download directory from previous server

Open
#331 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
react, typescript
Domain
frontend

Research direction

Locate the Add Magnet dialog and the server-tab change handling, then reproduce the issue by adding magnets on Server 1 before switching to Server 2. Verify the download directory and saved-directory list refresh for the selected server and that paths from the previous server are not reused.

Written by the indexing model from the issue text.

Description

fix-committed

Version: 512b63c

Steps to reproduce

  1. Select the Server 1 tab.
  2. Open the Add Magnet dialog.
  3. Paste multiple magnet links, one per line (This is how I reproduced it; it is unclear whether multiple links are required or merely make the issue easier to trigger.)
  4. Click Add.
  5. Immediately switch to the Server 2 tab.
  6. Open the Add Magnet dialog.

Actual behavior

The download directory field and its saved-directory list may still contain Server 1 paths.

If the torrent is added without noticing this, Server 2 can receive a path that does not exist on that server. This can cause an immediate path error or a failure when Transmission tries to move the completed download from its incomplete directory.

Expected behavior

The download directory should always be refreshed for the currently selected server. Paths from one server must never be reused for another server.

Reproducibility

It happened both times when I added the same set of magnets to two different servers.

It may require actually starting a multi-link addition before switching servers. I do not remember encountering it before multi-line magnet support was introduced.

Dominant language
TypeScript
Stars
819
Forks
109
Avg merge
8d 57m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openscopeproject/TrguiNG

All issues in openscopeproject/TrguiNG

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.