Support Java 25 module import declarations (JEP 511)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with ReloadableJava25ParserVisitor.visitImport and the parser/printer changes in #5997. Read the prior discussion of J.Import versus a separate module-import model, including ImportTree's JCImport and JCModuleImport forms. Done means import module java.base; parses without cursor desynchronization and passes the print idempotency check.
Written by the indexing model from the issue text.
Description
What problem are you trying to solve?
import module java.base; (JEP 511) isn't handled by the parser. ReloadableJava25ParserVisitor.visitImport only looks at isStatic(), never ImportTree.isModule(), so the module keyword is left unconsumed and the source cursor desyncs. The result isn't a clean failure but corrupted output:
-import module java.base;
+import javale java.base;
Any project using module imports therefore fails the print idempotency check.
Prior work
-
#5993 was closed with the JEP 511 box unchecked.
-
#5997 implemented this as a
moduleflag onJ.Import(next tostatik), and was closed unmerged:I don't approve of the approach. The JLS and compiler itself differentiate between module imports and non-imports, and I think it will add complexity to every import-related features if
J.Importrepresents both. Closing and will redo at a later time.— @jkschneider, https://github.com/openrewrite/rewrite/pull/5997#issuecomment-3835776840
-
The review on that PR had already framed the choice. @Laurens-W noted that
ImportTreecan now be either aJCImportor aJCModuleImport, and laid out the two options: a newJ.ModuleImportplus a sharedImportinterface (isStatic()/isModule()/getQualid()), which makesCompilationUnitreturn the interface rather than the implementation and requires refactoring the existingJ.Importusages; or themoduleflag, which "leaves surface for issues later on". -
@sambsnyd noted that a model change here needs a SaaS deployment queued after merge.
-
The parser and printer changes in #5997 remain a useful reference however the LST ends up being modelled.
- Dominant language
- Java
- Stars
- 3.9k
- Forks
- 599
- Avg merge
- 9h 38m
- Merged PRs (30d)
- 557
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openrewrite/rewrite
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
openrewrite/rewrite#9835 ·
Maintainers usually reply within 1 day
-
bug gradle
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
openrewrite/rewrite#7576 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
openrewrite/rewrite#9834 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
openrewrite/rewrite#9819 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 55/100
openrewrite/rewrite#9817 ·
Maintainers usually reply within 1 day
All issues in openrewrite/rewrite
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
aws/aws-emulator#30 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 4 days
-
Bug: Minor Status: Triage
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
GTNewHorizons/GT-New-Horizons-Modpack#27664 · 1 comment ·
Maintainers usually reply within 1 day
-
serviceability
Difficulty 1/5 Under an hour Newbie friendliness 65/100
OpenLiberty/open-liberty#36348 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Stirling-Tools/Stirling-PDF#8875 · 1 reaction ·
Maintainers usually reply within 2 days