Default values for impute's references

Open
#286 5 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by locating the impute entry point and its references argument, then inspect existing tests or documentation for reference handling. Done means defining the default behavior when references is omitted and adding coverage for inference from the group labels.

Written by the indexing model from the issue text.

Description

To be evaluated

I was wondering whether we should provide default values for references in impute ? As in I imagine in 90% of cases people are just going to do c("placebo" = "placebo", "treatment" = "placebo") so I'm wondering if we should just automatically infer this based upon the labels of the group variable if nothing is passed to the arguement (just makes it slightly easier for users I am thinking)

i.e. (pseudo code)

if  references is null:
    labels = levels(groups)
    references  =  c(
        labels[1] = labels[1],  
        labels[2] = labels[1]
    )
Dominant language
R
Stars
21
Forks
13
Avg merge
13h 22m
Merged PRs (30d)
7

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openpharma/rbmi

All issues in openpharma/rbmi

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.