Add a function to customize deletion order for shortcut testing

Open
  • Is something wrong?
#58 0 comments 0 reactions 1 assignee View on GitHub

@EeethB is already working on this.

Since Aug 17, 2023.

Assessment

This issue has not been assessed yet.

Description

enhancement

Simply deleting hypotheses in a custom order is not difficult. The main hurdle is figuring out valid deletion orders. First, all rejected hypotheses must come before non-rejected, which is easy once you have initial test results. But the rejected ones cannot necessarily go in any order, as deleting one hypothesis increases weights of other hypotheses. The simplest route from a coding perspective would probably be to just loop over every permutation of rejected hypotheses and mark them as valid or not. But this would get slow very quickly. I think there's some way to do it using tricks with the closure. Like checking each row of the closure to see if there's a path to it using its parent rows. I guess parents of each row could be calculated on the fly by replacing each 0 with a 1, that might not be so slow. But there should be a formula method similar to what's used in graph_generate_weights().

Dominant language
R
Stars
23
Forks
1
Avg merge
1h 42m
Merged PRs (30d)
3

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openpharma/graphicalMCP

All issues in openpharma/graphicalMCP

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.