Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Retain Cycle due to strong reference to PresentingViewController

Open
  • Is something wrong?
#920 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
objective-c
Domain
authentication, mobile-dev

Research direction

Start by reviewing PR #919 and the AppAuth initialization path that receives the presentingViewController. Compare the proposed ownership change with the reported singleton lifecycle, then verify that the presenting controller can be released without a retain cycle; done means the regression is covered and the existing SDK behavior remains intact.

Written by the indexing model from the issue text.

Description

bug triage

Describe the bug
When initialize AppAuth in singleton and then pass the presentingViewController, it's resulting in retain cycle.

So we have created this PR, which based on our fork that we are using for almost a year or more with no noticeable issue:
https://github.com/openid/AppAuth-iOS/pull/919

Dominant language
Objective-C
Stars
2k
Forks
868
Avg merge
9d 20h
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openid/AppAuth-iOS

All issues in openid/AppAuth-iOS

Similar issues

More Objective-C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.