Import a QGIS style with its reads made on a thread
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Start in cmd/reads.rs: read reads::prepare and reads::ahead and follow one existing arm (e.g. Add Data or Reload Data) end to end to see how pre-read data is handed to the command. Then find the style.importQgis command and its .qml and image-marker reads, and mirror that pattern with a new arm; leave project.importQgis alone since it runs other commands. Done means the import reads happen off the command thread, so the import offers Cancel and progress like the other commands, with existing import tests still passing.
Written by the indexing model from the issue text.
Description
style.importQgis reads its .qml file on the command's thread, and since #2612 it also reads its raster image markers' images there: up to 64 MiB, each file decoded once to check it. The work is bounded, but a slow disk or network share can hold the window, with no Cancel.
cmd/reads.rs already makes the reads of Add Data, Reload Data, Convert To Annotation and others on a thread before the command lands (reads::ahead). Proposal: a style.importQgis arm in reads::prepare that reads the style and its images there and hands them to the command, so the import gets Cancel and progress like those commands. project.importQgis is a separate case, because it runs other commands as it goes. Raised in review of #2612.
- Dominant language
- Rust
- Stars
- 1.9k
- Forks
- 268
- Avg merge
- 11h 1m
- Merged PRs (30d)
- 942
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opengeos/RustGIS
-
[Bug]: layer.move to the place a layer already has fails and stops a script; with several layers it leaves an empty undo stepPossibly taken @jgregoriorincon claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
opengeos/RustGIS#2621 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
opengeos/RustGIS#1446 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: A text box's suggestion list tells a screen reader nothing about the highlighted entryPossibly taken @jgregoriorincon claimed this today. Openunconfirmed possible issue
Difficulty 3/5 1-2 days Newbie friendliness 62/100
opengeos/RustGIS#2619 · 1 comment ·
Maintainers usually reply within 1 day
All issues in opengeos/RustGIS
Similar issues
-
文件夹重大BUG:不支持重命名Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
postgresql-rules / queue-rules: implicit KEY SHARE before a parent key update, and job self-overlapOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jonathanong/no-mistakes#3879 ·
Maintainers usually reply within 1 day
-
area:index v0.35.0
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
pbakaus/impeccable#1653 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
nautechsystems/nautilus_trader#5741 ·
Maintainers usually reply within 1 day