Show which units are disabled in the lobby finder

Open Beginner friendly
#5,589 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
frontend, game-dev

Research direction

Start by locating the lobby finder UI and the existing “Disabled units: ” pill. Trace where the disabled-unit count is assembled and how the lobby displays unit details. Done means the finder shows the list of disabled units without requiring a player to join the lobby.

Written by the indexing model from the issue text.

Description

not-approved

Is your feature request related to a problem? Please describe.
Currently disabled units are only detailled in the lobby itself and the lobby finder only indicates the number of units, so it's annoying to join in order to have this information.

Describe the solution you'd like
Expand the "Disabled units: " pill to display the list of disabled units.

Describe alternatives you've considered
We could also add a tooltip when the pill is hovered that would display the list, but it's not terrible for game accessibility.

Additional context
It was suggested by Dipaka in this thread: https://discord.com/channels/1284581928254701718/1550559244422484119

Assignment

  • I'd like to be assigned to this issue and work on it myself
Dominant language
TypeScript
Stars
2.7k
Forks
1.4k
Avg merge
16h 33m
Merged PRs (30d)
329

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openfrontio/OpenFrontIO

All issues in openfrontio/OpenFrontIO

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.