Allow click on player name to lead to public profile

Open Beginner friendly
#5,558 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
frontend, game-dev

Research direction

Locate the post-game stats page and the component that renders each player row, then inspect the existing public profile route or link pattern. Make the player row open that player's public profile, and verify the destination uses the correct public id and works from the completed-game stats view.

Written by the indexing model from the issue text.

Description

not-approved

Is your feature request related to a problem? Please describe.

We can find the public id of a player by doing some minimal reverse engineering (the https://api.openfront.io/game/{game-id} endpoint returns the list of players with their public id, so we can find it easily from dev tools for instance)

But we can't simply click on the player in the stats page (after a game is over).

Describe the solution you'd like

I'd like the row for the player to be clickable so that I can directly open their profile.

Image

Describe alternatives you've considered

A searchbar for players based on either their public id, their reserved username or their recently used in-game username would be nice, but will create a separate Feature Request for it.

Additional context

This should be a very straight-forward and minimal change if accepted.

Note: there might be other places where we can add a link to public profiles, not sure of all applicable places - happy to implement it everywhere.

Assignment

  • I'd like to be assigned to this issue and work on it myself
Dominant language
TypeScript
Stars
2.7k
Forks
1.4k
Avg merge
16h 33m
Merged PRs (30d)
329

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openfrontio/OpenFrontIO

All issues in openfrontio/OpenFrontIO

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.