[BUG] `set_time_series_active_power_predefined` creates a database engine although the time series are given as DataFrames
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Read edisgo/edisgo.py around set_time_series_active_power_predefined at line 420 and the engine selection at line 603. Run tests/properties/test_properties_edisgo.py::TestTopologyAndIntegrity::test_predefined_time_series_from_dataframes_need_no_database to confirm the failure. Make engine creation happen only in branches that fetch database data; the DataFrame case should pass without calling egon_engine().
Written by the indexing model from the issue text.
Description
Summary
Without an engine keyword, set_time_series_active_power_predefined always calls egon_engine(), also when all time series are passed as DataFrames or come from demandlib. With an egon-data config present this opens an SSH tunnel; without database access it fails, although no data are fetched.
Where
edisgo/edisgo.py:420 set_time_series_active_power_predefined, engine = kwargs["engine"] if "engine" in kwargs else egon_engine() at edisgo.py:603.
How to reproduce
Test (strict xfail, added in #856): tests/properties/test_properties_edisgo.py::TestTopologyAndIntegrity::test_predefined_time_series_from_dataframes_need_no_database (monkeypatches egon_engine to raise and passes conventional_loads_ts=<DataFrame>).
Proposed fix
Create the engine lazily, only in the branches that read from the database.
- Dominant language
- Python
- Stars
- 48
- Forks
- 22
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openego/eDisGo
-
bug correctness priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
[BUG] Spatial complexity reduction merges MV and LV buses when an LV grid has the ID of the MV gridOpenbug correctness priority: high
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug correctness priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area: opf documentation priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area: opf housekeeping priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gke-labs/kube-agents#5671 ·
Maintainers usually reply within 1 day
-
docs(auth): Method B step 4 should tell users to tick "Use this client for an AI-powered agent"Opendocumentation next-release v0.9.6
Difficulty 1/5 Under an hour Newbie friendliness 88/100
khuisman/mcp-gee-sweet#1446 ·
Maintainers usually reply within 1 day
-
model:sonnet runtime:claude security size:S
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
FootprintAI/Containarium#3671 ·
Maintainers usually reply within 1 day
-
HolidayBase: reassigning `language` does not re-initialize translations or re-populate holidaysPossibly taken @shikhabhadoria claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vacanza/holidays#4116 · 1 comment ·
Maintainers usually reply within 1 day
-
bug CLI exec
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day