Video: course-side title override of a library-synced Video is lost on sync (editor_saved doesn't call super)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 75/100
Research direction
Start with xblock_video.block.VideoBlock.editor_saved() and compare it with cms.lib.xblock.upstream_sync.UpstreamSyncMixin.editor_saved(); the issue says the built-in video block has the same override. Find the Video tests covering editor saves and downstream sync, then add coverage showing a customized display_name survives an accepted library update. Done when that test passes and the video save still calls VideoConfigService.handle_editor_saved(...).
Written by the indexing model from the issue text.
Description
Summary
For a Video reused from a Content Library V2 into a course, a course-side title override is overwritten by the next sync from the library. The same flow keeps the override for HTML, Word Cloud, LTI and Problem.
Steps to reproduce
Found while smoke-testing openedx/openedx-platform#38750 on a local Tutor nightly (platform master base + xblocks-core 2.0.0):
- Publish a Video in a V2 library and reuse it in a course unit (Library content).
- In the course, change the reused copy's display name to "Course override".
- In the library, rename the video and publish.
- Accept the update in the course (
POST /api/contentstore/v2/downstreams/<usage>/sync).
Expected: "Course override" is kept (display_name is customizable by default).
Actual: the title becomes the library's new name.
Cause
The platform mixes cms.lib.xblock.upstream_sync.UpstreamSyncMixin into every XBlock (XBLOCK_MIXINS). Its editor_saved() records customized fields in downstream_customized. xblock_video.block.VideoBlock.editor_saved() overrides it and only calls VideoConfigService.handle_editor_saved(...), never super().editor_saved(...). So for a mixed Video class, editor_saved resolves to VideoBlock.editor_saved, and the override is never recorded. For HTML it resolves to UpstreamSyncMixin.editor_saved (checked in a CMS shell).
This predates the extraction: the built-in xmodule/video_block/video_block.py::editor_saved is identical.
Suggested fix
Call super().editor_saved(user, old_metadata, old_content) from VideoBlock.editor_saved (when the parent defines it), plus a test that a customized display_name survives a sync.
| Generated using Claude Code
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 19
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 9
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openedx/xblocks-core
-
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
openedx/xblocks-core#305 ·
Maintainers usually reply within 1 day
-
Update localization docs | xblocks-core, xblocks-extraPossibly taken @farhan claimed this 1 day ago. Open
openedx/xblocks-core#333 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 43/100
openedx/xblocks-core#332 ·
Maintainers usually reply within 1 day
-
Annotatable: newly created empty block in a Content Library V2 fails to render (XMLSyntaxError: Document is empty)Possibly taken @irfanuddinahmad claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 65/100
openedx/xblocks-core#323 · 1 comment ·
Maintainers usually reply within 1 day
-
ChoiceTextResponse: a submission that omits a required numtolerance_input key is graded correctOpen
Difficulty 3/5 1-2 days Newbie friendliness 65/100
openedx/xblocks-core#306 ·
Maintainers usually reply within 1 day
All issues in openedx/xblocks-core
Similar issues
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HarperFast/rocksdb-js#1131 ·
Maintainers usually reply within 1 day
-
Reveal: resolved but blocked Pending boundary hides its fallbackPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
anothaDev/luci-theme-vantage#137 ·
Maintainers usually reply within 1 day
-
Area/DeveloperPortal Aspect/UI Severity/Minor Type/Bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
wso2/api-platform#4369 ·
Maintainers usually reply within 1 day