Figure out the future of the OSPR Bot
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
Research direction
Start by reviewing the linked openedx-webhooks pull request 159 and the current GitHub OAuth or personal-access-token setup described here. Resolve who depends on and maintains the bot, where issues belong, and whether a GitHub App or OAuth App is the intended future integration; done requires an agreed direction rather than a code change.
Written by the indexing model from the issue text.
Description
Decoupling questions
In light of the edX-tCRIL decoupling and increasing distribution of code ownership...
Who will depend on the bot, and for what?
- edX: creating and linking Jira tickets for each OSPR on the Jira project of the owning team.
- tCRIL: putting OSPRs on our team project board for code we own?
- others firms: pushing to their preferred issue tracking system when a PR is opened on owned code?
- tCRIL: automating the CLA flow by hooking into Salesforce.
- anything else?
Who will maintain the bot?
- edX Arch-BOM?
- tCRIL?
Where do bot-related issues go?
- edX Jira, in the BOM project?
- this tcril-engineering GitHub repo?
Other issues
Cataloging these here until we have a proper place for issues.
Personal access token vs App
Until recently, the OSPR bot was implemented as an OAuth App in GitHub. Because the openedx GitHub org is configured not to allow arbitrary OAuth Application access, we either needed to
(i) do the legwork to make the OSPR bot an approved OAuth App, or
(ii) change the bot to use a personal access token from the openedx-webhooks account, or
(iii) change the openedx GitHub org to allow arbitrary OAuth application access.
We took approach (ii).
We have some concern that because this is not the "proper" way to integrate with GitHub (they technically have a one-user-account-per-human policy) that this may expose us to being rate-limited more aggressively than if it were a proper OAuth App or GitHub App (which, mind you, are different things). For now, we've decided to proceed with a personal access token, with Ned keeping an eye on the logs to see if we're approaching or hitting a rate limit.
In the future, though, it would probably be prudent to turn the OSPR bot into an approved GitHub App or OAuth App.
- Dominant language
- Python
- Stars
- 13
- Forks
- 22
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 6
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openedx/openedx-webhooks
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
openedx/openedx-webhooks#469 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
openedx/openedx-webhooks#391 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
openedx/openedx-webhooks#319 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
openedx/openedx-webhooks#312 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
openedx/openedx-webhooks#285 ·
Maintainers usually reply within 1 day
All issues in openedx/openedx-webhooks
Similar issues
-
opensubtitlescom: provider rejects pt-PT even though its own converter maps itPossibly taken @paulo-0308 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Diaoul/subliminal#1405 ·
-
Internal ErrorOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
frappe/frappe_docker#2071 ·
Maintainers usually reply within 1 day
-
bug python
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
traceloop/openllmetry#4717 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
The-Pocket/PocketFlow#161 ·
-
comp/desktop P2 type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NousResearch/hermes-agent#157702 ·
Maintainers usually reply within 1 day