MFEs aren't changing html lang attribute
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript
- Domain
- frontend, internationalization
Research direction
Start in src/i18n/lib.js at the i18n configure function around line 262, and compare the existing handleRtl behavior with the issue's suggested HTML update. Verify the MFE document's html lang attribute changes to the configured locale after loading a non-en-us language; done means the attribute reflects getLocale().
Written by the indexing model from the issue text.
Description
When loading MFE using a language different than en-us. Eg: change the preferred language on the account MFE.
When we reload any MFE page, the lang html attribute didn't change even the application is translated to that new different language.
I think the MFEs should change the html lang attribute when it has been loaded with different language.
<html lang="en-us" dir="ltr">
Suggested change:
I think that the i18n configure function should change that value.
https://github.com/openedx/frontend-platform/blob/07ee86cf54d26dd1a8a98e24cf1a402e98157f61/src/i18n/lib.js#L262
Create a similar Should have a handleHTMLLang similar to handleRtl function, with code:
globalThis.document.getElementsByTagName('html')[0].setAttribute('lang', getLocale());
- Dominant language
- JavaScript
- Stars
- 39
- Forks
- 91
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openedx/frontend-platform
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
openedx/frontend-platform#892 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
openedx/frontend-platform#837 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
openedx/frontend-platform#835 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
openedx/frontend-platform#833 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
openedx/frontend-platform#764 ·
All issues in openedx/frontend-platform
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·
-
client-controller-update ta-bot-triage team-money-movement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
MetaMask/metamask-mobile#36594 ·