Header Sign in and Register buttons drop the return URL
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Read shell/header/anonymous-menu/LoginButton.tsx and RegisterButton.tsx, then compare their links with the legacy AnonymousUserMenu.jsx behavior linked in the issue. Check how the shell gets the current page URL and run the relevant button tests if available. Done when both links include a return URL so users land back on the page they left.
Written by the indexing model from the issue text.
Description
Description
When an anonymous user clicks Sign in or Register in the shell header, they don't come back to the page they were on.
The legacy learning header sent the current page along: Register went to /register?next=<current page>, and Sign in used getLoginRedirectUrl() with the current URL.
The shell's LoginButton and RegisterButton link to the bare login and register URLs, with no next. This matters most on course pages, which is exactly where the legacy learning header was used.
Found by reading the code. I haven't reproduced it in a browser yet.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 13
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 4
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openedx/frontend-base
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
openedx/frontend-base#357 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
openedx/frontend-base#330 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
openedx/frontend-base#327 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openedx/frontend-base#210 ·
Maintainers usually reply within 1 day
-
Xylon DEPRsOpen
Difficulty 5/5 Over a week Newbie friendliness 20/100
openedx/frontend-base#360 ·
Maintainers usually reply within 1 day
All issues in openedx/frontend-base
Similar issues
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
device-management-toolkit/sample-web-ui#3711 ·
Maintainers usually reply within 1 day
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
elastic/kibana#306401 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
agentes-chat/agentes-chat#927 ·
Maintainers usually reply within 1 day
-
Closing a pinned tab jumps to the Tabs section instead of the next open pinned tabPossibly taken @seenimohamed claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ardia-browser/ardia#2769 ·
Maintainers usually reply within 1 day