Historical preimage lookup uses AND instead of OR for three-timestamp histories
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- swift
- Domain
- blockchain
Research direction
Open Blockchain/Sources/Blockchain/State/State.swift at State.historicalLookup around line 417 and compare the three-timestamp condition with Graypaper v0.7.2 and v0.8.0 §9.2.1, equation 9.7. Done means three-timestamp histories use the two availability periods defined by the specification rather than requiring both periods simultaneously.
Written by the indexing model from the issue text.
Description
State.historicalLookup in Blockchain/Sources/Blockchain/State/State.swift:417 checks a three-timestamp history [x, y, z] using:
x <= timeslot && timeslot < y && z <= timeslot
Both Graypaper v0.7.2 and v0.8.0, §9.2.1 (“Invariants”), equation 9.7, define availability for [x, y, z] as:
(x ≤ timeslot < y) OR (z ≤ timeslot)
The implementation should use OR between the two availability periods.
- Dominant language
- Swift
- Stars
- 6
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from open-web3-stack/boka
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
open-web3-stack/boka#386 ·
-
linux binary buildOpen
Difficulty 4/5 3-5 days Newbie friendliness 42/100
open-web3-stack/boka#354 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
open-web3-stack/boka#347 ·
-
update msquic buildOpen
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
open-web3-stack/boka#333 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
open-web3-stack/boka#331 ·
All issues in open-web3-stack/boka
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
permissionlesstech/bitchat#1743 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
521xueweihan/HelloGitHub#3816 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jamesmontemagno/tiny-clips#378 · 2 comments ·
Maintainers usually reply within 1 day
-
图标看起来比其他应用小一圈Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100