Keyboard nav issues across nav layouts

Open
#91 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
scss

Research direction

The payload names no files. Start by locating the horizontal navigation and off-canvas menu markup and their toggle handling in the theme, and reproduce the keyboard behaviour with Tab and Enter on a parent a item. Done means a parent link can be activated by keyboard, the open submenu closes on toggle or focus move, and the off-canvas menu closes when the viewport widens so no horizontal scroll appears. Check the linked omeka-s-themes/foundation#81 for prior discussion.

Written by the indexing model from the issue text.

Description

Horizontal menu layout, from https://github.com/omeka/theme-foundation/issues/88#issuecomment-6857681552:

There's an issue external to this but related to toggle functionality: with the horizontal menu, it's not possible to actually activate a parent menu item link via keyboard. It can only be activated to toggle open a submenu. Additionally, the submenu does not dismiss with additional toggle activation nor by moving focus, so the open submenu remains an obstruction. The same has already been noted in the discussion for the S version of the theme (Keyboard a11y issues (etc.) across nav layouts omeka-s-themes/foundation#81).

Also, in both layouts, when the off-canvas menu is activated from a small enough viewport and the viewport is then widened without first closing the menu, the off-canvas menu remains open (so two types of nav menus appear on screen), and the screen gains horizontal scroll.

Dominant language
SCSS
Stars
5
Forks
4
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from omeka/theme-foundation

All issues in omeka/theme-foundation

Similar issues

More Accessibility issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.