Keyboard nav issues across nav layouts
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- scss
- Domain
- accessibility, frontend
Research direction
The payload names no files. Start by locating the horizontal navigation and off-canvas menu markup and their toggle handling in the theme, and reproduce the keyboard behaviour with Tab and Enter on a parent a item. Done means a parent link can be activated by keyboard, the open submenu closes on toggle or focus move, and the off-canvas menu closes when the viewport widens so no horizontal scroll appears. Check the linked omeka-s-themes/foundation#81 for prior discussion.
Written by the indexing model from the issue text.
Description
Horizontal menu layout, from https://github.com/omeka/theme-foundation/issues/88#issuecomment-6857681552:
There's an issue external to this but related to toggle functionality: with the horizontal menu, it's not possible to actually activate a parent menu item link via keyboard. It can only be activated to toggle open a submenu. Additionally, the submenu does not dismiss with additional toggle activation nor by moving focus, so the open submenu remains an obstruction. The same has already been noted in the discussion for the S version of the theme (Keyboard a11y issues (etc.) across nav layouts omeka-s-themes/foundation#81).
Also, in both layouts, when the off-canvas menu is activated from a small enough viewport and the viewport is then widened without first closing the menu, the off-canvas menu remains open (so two types of nav menus appear on screen), and the screen gains horizontal scroll.
- Dominant language
- SCSS
- Stars
- 5
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/theme-foundation
-
UI element contrastOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
omeka/theme-foundation#87 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
omeka/theme-foundation#86 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
omeka/theme-foundation#90 · 1 comment ·
-
Typo in theme configOpen
Difficulty 1/5 Under an hour Newbie friendliness 56/100
omeka/theme-foundation#85 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
omeka/theme-foundation#83 ·
All issues in omeka/theme-foundation
Similar issues
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
keyxmakerx/Chronicle#2563 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eventua11y/eventua11y.com#974 ·
Maintainers usually reply within 1 day
-
type:task ux
Difficulty 1/5 Under an hour Newbie friendliness 78/100
elsa-workflows/elsa-foundation#5228 ·
Maintainers usually reply within 1 day