Broken urls for tags that include double spaces
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start by locating the code that creates tag directories and the views that generate tag links. Compare how both paths normalize tags containing double spaces, then verify that exported links resolve to the generated directory name for a tag such as Walsh Edmund A.
Written by the indexing model from the issue text.
Description
Omeka seems to allow for tags to include double spaces, though they render as a single space. For example, some imported items I used in my local installation have tags like Walsh Edmund A that render like Walsh Edmund A. In Omeka, the query looks like tags=Walsh++Edmund+A. In the export from this plugin, the directory generated has the name walsh--edmund-a, but all tag links look for walsh-edmund-a.
I feel like the core shouldn't allow for those double spaces, especially if it renders as a single space as it's pretty confusing. In the meantime, if the plugin picks up on those double spaces while creating directories, it should probably use the same logic for generating tag urls in the views.
- Dominant language
- PHP
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/plugin-StaticSiteExport
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
All issues in omeka/plugin-StaticSiteExport
Similar issues
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day