Consider making ExhibitPageBlock->findByPage() use getSelectForF
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Locate ExhibitPageBlock->findByPage() and compare its current getSelect() call with getSelectForF and the browseSql hook. Done means the hook can filter returned blocks without breaking existing behavior; no test file is named in the issue.
Written by the indexing model from the issue text.
Description
Just a possibility under review for some of the Getty plugins.
Currently, that function uses getSelect() directly, which means that a plugin can't intervene via the browseSql hook. If it switched to allow that hook to operate, plugins could add a layer of filtering on the blocks that are returned.
- Dominant language
- PHP
- Stars
- 25
- Forks
- 37
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/plugin-ExhibitBuilder
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
UI element contrastOpena11y
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
omeka/plugin-ExhibitBuilder#166 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
omeka/plugin-ExhibitBuilder#165 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
omeka/plugin-ExhibitBuilder#163 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#161 ·
All issues in omeka/plugin-ExhibitBuilder
Similar issues
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Memcached cache adapter keeps items whose TTL has expiredPossibly taken A pull request linked to this issue is open or already merged. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quantum-php/framework#692 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day