Consider making ExhibitPageBlock->findByPage() use getSelectForF

Open
#93 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
backend

Research direction

Locate ExhibitPageBlock->findByPage() and compare its current getSelect() call with getSelectForF and the browseSql hook. Done means the hook can filter returned blocks without breaking existing behavior; no test file is named in the issue.

Written by the indexing model from the issue text.

Description

Just a possibility under review for some of the Getty plugins.

Currently, that function uses getSelect() directly, which means that a plugin can't intervene via the browseSql hook. If it switched to allow that hook to operate, plugins could add a layer of filtering on the blocks that are returned.

Dominant language
PHP
Stars
25
Forks
37
Avg merge
5d 19h
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from omeka/plugin-ExhibitBuilder

All issues in omeka/plugin-ExhibitBuilder

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.