Feature Request: Add exhibit_builder_nested_nav() function like the one in Omeka 1.x versions
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by locating the current exhibit section and page navigation entry points, then compare their behavior with the Omeka 1.x exhibit_builder_nested_nav() example in this issue. Determine how the current version represents exhibits, sections, and pages before deciding where the equivalent function belongs. Done means nested section navigation supports current-section handling and the showAllPages option without breaking existing navigation.
Written by the indexing model from the issue text.
Description
The code from the previous versions was this:
function exhibit_builder_nested_nav($exhibit = null, $showAllPages = false)
{
if (!$exhibit) {
if (!($exhibit = exhibit_builder_get_current_exhibit())) {
return;
}
}
$html = '<ul class="exhibit-section-nav">';
foreach ($exhibit->Sections as $exhibitSection) {
$html .= '<li class="exhibit-nested-section' . (exhibit_builder_is_current_section($exhibitSection) ? ' current' : '') . '"><a class="exhibit-section-title" href="' . html_escape(exhibit_builder_exhibit_uri($exhibit, $exhibitSection)) . '">' . html_escape($exhibitSection->title) . '</a>';
if ($showAllPages || exhibit_builder_is_current_section($exhibitSection)) {
$html .= exhibit_builder_page_nav($exhibitSection);
}
$html .= '</li>';
}
$html .= '</ul>';
$html = apply_filters('exhibit_builder_nested_nav', $html, $exhibit, $showAllPages);
return $html;
}
It'd be great if there were something similar in the current version. If there are no plans to do this, I might write this function myself, although it'll take me quite a while to figure everything out.
- Dominant language
- PHP
- Stars
- 25
- Forks
- 37
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/plugin-ExhibitBuilder
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
UI element contrastOpena11y
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
omeka/plugin-ExhibitBuilder#166 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
omeka/plugin-ExhibitBuilder#165 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
omeka/plugin-ExhibitBuilder#163 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#161 ·
All issues in omeka/plugin-ExhibitBuilder
Similar issues
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Memcached cache adapter keeps items whose TTL has expiredPossibly taken A pull request linked to this issue is open or already merged. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quantum-php/framework#692 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day