Upgrade can fail if exhibits with "zero" dates exist

Open
#122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
44/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
mysql, php
Domain
database

Research direction

Start by locating the upgrade code that already fixes the default dates and inspect how the table alteration is performed for MySQL. Done means existing zero dates are replaced during that upgrade so unrelated table alters no longer fail on MySQL.

Written by the indexing model from the issue text.

Description

We already handle the "early" fixing of the default dates, but new mysqls will choke even on unrelated alters to the table if any zero dates are contained within. We'd need to replace any zero dates at the same time we're fixing the defaults.

Dominant language
PHP
Stars
25
Forks
37
Avg merge
5d 19h
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from omeka/plugin-ExhibitBuilder

All issues in omeka/plugin-ExhibitBuilder

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.