theme_options filter isn't always triggered for exhibit themes
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start with Omeka_Form_ThemeConfiguration::init() and Theme::getOptions(), then trace how Exhibit Builder loads saved theme options from the exhibits table. Reproduce the configuration flow described in the issue and verify that theme_options is invoked both before and after saving configuration.
Written by the indexing model from the issue text.
Description
Once I've saved an exhibit's theme configuration, I can no longer access the values via the theme_options filter. Omeka_Form_ThemeConfiguration::init() does call this filter via Theme::getOptions() if nothing has been saved, but Exhibit Builder never calls the filter if theme options have been loaded from the exhibits table.
Steps to reproduce
- Implement the theme_options filter in a plugin class like so:
protected $_filters = ['theme_options'];
public function filterThemeOptions($serializedOptions, $args)
{
echo 'asdf';
return $serializedOptions;
}
- Edit an exhibit, switch to another theme, and configure it.
- Notice the 'asdf' at the bottom of the page.
- Save the theme configuration form.
- Press Configure again.
Expected behavior
'asdf' should still be at the bottom of the page.
Actual behavior
'asdf' is not present.
- Dominant language
- PHP
- Stars
- 25
- Forks
- 37
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/plugin-ExhibitBuilder
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
UI element contrastOpena11y
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
omeka/plugin-ExhibitBuilder#166 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
omeka/plugin-ExhibitBuilder#165 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
omeka/plugin-ExhibitBuilder#163 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#161 ·
All issues in omeka/plugin-ExhibitBuilder
Similar issues
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Memcached cache adapter keeps items whose TTL has expiredPossibly taken A pull request linked to this issue is open or already merged. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quantum-php/framework#692 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day