Filename and web path

Open
#66 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
32/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
backend

Research direction

The bug is in how CsvImport sets original_filename for files fetched by URL, so start with the file-import code path in the plugin and the place where the source URL is passed to Omeka core's file downloading. Confirm the bug by importing a row whose file column is a URL like http://example.org/tmp/myfile.jpg and checking the stored original_filename. Done means the stored name is myfile.jpg, verified by a test or a manual import. Core download handling may need to change, so check with maintainers first.

Written by the indexing model from the issue text.

Description

Currently, when CSVImport is used to add items with files, the newly created files received an original_filename that is the full web path of the file. That would be great to just get the filename as the web path will often be a temporary path, used to allow CSVImport to get the files over the web.

To add an example, when adding a record, I don't want the file to have for original_filename:
http://example.org/tmp/myfile.jpg but rather myfile.jpg

I am not sure that just a CsvImport fix could fix that with the current way omeka core handle file downloading.

Dominant language
PHP
Stars
20
Forks
32
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from omeka/plugin-CsvImport

All issues in omeka/plugin-CsvImport

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.