Theme styling: touch targets, contrast, etc.
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- css
- Domain
- accessibility, frontend
Research direction
Start by reviewing the theme-specific issues linked here, especially Berlin's input styles and Seasons' contrast notes, then inspect the corresponding styles for the listed themes. Check touch target sizes, text contrast, link behavior, and input boundaries against the stated requirements. Done means the listed issues meet those accessibility checks across the affected themes; no test files or style entry points are named in the issue.
Written by the indexing model from the issue text.
Description
- All themes must ensure Flag/Unflag and Reply actions as well as user website links meet the minimum standards (24 x 24 px) for touch target sizing. In the case here, most themes are under the 24px height requirement.
- Noted by specific theme, other areas with target sizing issues include:
- Berlin: Submit button, text inputs
- Noted by specific theme, other areas with target sizing issues include:
- There is a quirk across all themes (Berlin, Lively, Freedom, etc.) that properly display links with underlines, in which the Flag/Unflag link displays with only a partial underline:
However, I believe these links should be converted to buttons anyway. - Noted by specific theme, areas with contrast issues include:
- Center Row: Submit button (4.2:1, should be 4.5:1 at min)
- Seasons:
- Inputs as described in theme issue https://github.com/omeka/theme-seasons/issues/52#issuecomment-6783426922
- "Flagged inappropriate" text:
- Night: 1:1
- Winter: 4.484:1
- Summer: 2.991:1
- Night: 1:1
- Freedom and Lively: "Flagged inappropriate" text (3.7:1)
- We also need to ensure text inputs have accessible boundary styles, as already described in theme-specific issues (e.g. https://github.com/omeka/theme-berlin/issues/42) regarding inputs in search forms. I would imagine those corrected styles should carry over for this, but if not, I can note specific issue areas here.
- Dominant language
- PHP
- Stars
- 4
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from omeka/plugin-Commenting
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
omeka/plugin-Commenting#70 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
omeka/plugin-Commenting#67 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
omeka/plugin-Commenting#64 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
omeka/plugin-Commenting#63 ·
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
omeka/plugin-Commenting#62 ·
All issues in omeka/plugin-Commenting
Similar issues
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
a11y
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
omeka/plugin-ExhibitBuilder#169 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day