Convert anchors to buttons

Open
#65 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
html

Research direction

Start by locating the browse-table and public-view markup for .show-toggle, .approval-action, .flag-action, .delete-confirm, and .reply-action. Check how the item links’ external-link icons are labeled for screen readers. Done means the listed actions use buttons and the external links have screen-reader labels; the optional styling request may need clarification.

Written by the indexing model from the issue text.

Description

a11y

In browse table:

As mentioned in https://github.com/omeka/plugin-Commenting/issues/64, the .show-toggle links should be converted to buttons. This is also true for the following:

  • .approval-action
  • .flag-action
  • Initial .delete-confirm

On a semi-related note, links to items have external link icons but are missing external link labeling for screen readers. Some refined styling could also be welcome to move things inline:

Detail of Item column in browse table with item link 'Woodcut image 3' in view. On the next link after the item name, an external link icon appears.

Public view:

  • .flag-action
  • .reply-action
Dominant language
PHP
Stars
4
Forks
5
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from omeka/plugin-Commenting

All issues in omeka/plugin-Commenting

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.