perf: filetype sorter calls vim.filetype.match on every comparison
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 77/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- lua, neovim
- Domain
- backend, performance
Research direction
Start by reading the filetype sorter and the sort.sorter function path; the issue does not name their files, so locate them in the sorting code. Check how often vim.filetype.match runs during a sort and how the cache can be rebuilt on each sort. Done when each name is resolved once per sort, ordering stays identical, and the reported directory sort is faster.
Written by the indexing model from the issue text.
Description
Problem
With sort.sorter = "filetype", Sorter:filetype calls vim.filetype.match twice per comparison. A merge sort makes O(n log n) comparisons, and vim.filetype.match is expensive.
The sort.sorter function path also calls vim.filetype.match once per node.
Impact
Sorting a directory with 3.3k entries took 4459ms on master. This runs on every reload of that directory.
Proposed fix
Resolve each name's filetype once per sort, using a cache that is rebuilt on every sort so that vim.filetype.add changes still apply. In testing this brings the same sort down to 532ms, with identical ordering.
Environment: macOS, Nvim v0.13.0-dev, LuaJIT 2.1. Test repo: 16.8k files and folders, 3.1k git status entries (modified, untracked, ignored). Measured headless with vim.uv.hrtime() and the LuaJIT profiler (jit.p).
- Dominant language
- Lua
- Stars
- 8.7k
- Forks
- 642
- Avg merge
- 1d 4m
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nvim-tree/nvim-tree.lua
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nvim-tree/nvim-tree.lua#3383 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nvim-tree/nvim-tree.lua#3381 ·
Maintainers usually reply within 1 day
-
Use vim.Option getters and setters instead of directly settingPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nvim-tree/nvim-tree.lua#3357 · 1 comment ·
Maintainers usually reply within 1 day
-
Migrate To vim.packOpendocumentation PR please
Difficulty 1/5 Under an hour Newbie friendliness 65/100
nvim-tree/nvim-tree.lua#3179 · 6 comments ·
Maintainers usually reply within 1 day
-
perf: Filters:custom calls getcwd for every file, even with no custom filtersPossibly taken @hood claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
nvim-tree/nvim-tree.lua#3386 ·
Maintainers usually reply within 1 day
All issues in nvim-tree/nvim-tree.lua
Similar issues
-
bug confirmed discord guide:tyrs-watch locale:enUS navigation v0.3.2
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
fitzforge/polestar#855 · 1 comment ·
Maintainers usually reply within 1 day
-
Bug
Difficulty 1/5 Under an hour Newbie friendliness 91/100
DennisRas/WeeklyKnowledge#164 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
perf: <BS> runs regex compares for rules that can never deletePossibly taken @hood claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
windwp/nvim-autopairs#555 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 2 days