Improve 'mini.notify' to reduce LSP progress flicker
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reviewing the mini.notify module and its handling of LSP Progress updates. Examine the discussion's suggestions around ts_add ordering, MiniNotifyDone highlighting, config.window.wrap, and throttling; done means reducing notification flicker while deciding which of these changes belongs in the module.
Written by the indexing model from the issue text.
Description
Thanks for sharing and the feedback! I don't really work with Rust, but when testing it does look too flickery.
Couple of thoughts:
- Making notifications sorted based on
ts_addtime is not complicated to do manually, which you have. I do wonder if it indeed might be a good idea to have it by default. Probably would require extraMiniNotifyDonehighlight group to dim already finished tasks to easier differentiate from active ones. - I agree that not wrapping by default should be easier. I'll take a look, but adding
config.window.wraplooks reasonable. - Throttling LSP progress updates by default might also be a good idea. I'll also take a look.
I had an idea of revisiting 'mini.notify' to see if it can be naturally extended to show spinners and account for the new Progress event on Nightly, so this will be a good time to revisit all of these. Not sure about the time frame, though.
Originally posted by @echasnovski in https://github.com/nvim-mini/mini.nvim/discussions/36#discussioncomment-14549820
- Dominant language
- Lua
- Stars
- 9.6k
- Forks
- 314
- Avg merge
- 19h 10m
- Merged PRs (30d)
- 7
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nvim-mini/mini.nvim
-
feature-request mini.icons
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
'mini.nvim' and multicursorMay be free again @justinmk claimed this 33 days ago, and no pull request is open. OpenALL neovim-upstream
Difficulty 5/5 Over a week Newbie friendliness 28/100
-
mini.statuscolumn
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
feature-request mini.surround
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
new-module
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in nvim-mini/mini.nvim
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jangala-dev/devicecode-lua#344 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
LuaLS/lua-language-server#3481 ·
-
Kill Ishamuhale for Ishamuhale's FangPossibly taken A pull request linked to this issue is open or already merged. Openbug discord guide:04-the-barrens locale:enUS triage v0.2.6
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Balatro-Potato-Patch/Wormhole#145 ·