Required static check never reports on fork pull requests
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 67/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Read .github/workflows/build-static-tests.yaml and compare its triggers with ci.yml; the issue identifies both files and the fork pull request behavior to investigate. Decide whether to enable the required check for fork pull requests or document that forks are not supported, while avoiding duplicate same-repository runs. Done when the chosen behavior is implemented and the check can report for fork pull requests, or the contribution limitation is documented.
Written by the indexing model from the issue text.
Description
static / Static CI Tests is a required check on develop (declared in .github/settings.yml since #55, previously set by hand), but .github/workflows/build-static-tests.yaml triggers only on push:. A pull request from a fork never produces that context for its head SHA, so with strict: true and enforce_admins: true it can never become mergeable.
Same-repo branches (including Renovate) are unaffected because their pushes run the workflow.
Options: add pull_request: to build-static-tests.yaml (watch for duplicate runs on same-repo PR pushes; a push: branches: [develop] + pull_request: split like ci.yml avoids that), or accept that forks aren't a contribution path and note it in the contributing docs.
Found in the review of #55.
- Dominant language
- Shell
- Stars
- 0
- Forks
- 0
- Avg merge
- 11m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nolte/taskfiles
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
worktree:add: quote CLI args and derive repo name from the fetch remotePossibly taken @nolte claimed this 11 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 67/100
-
worktree: harden the add prefix check and widen the self-testPossibly taken @nolte claimed this 11 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nolte/kamerplanter-appliance#32 ·
Maintainers usually reply within 1 day
-
research
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
slayerlabs/benchmarks-fabryka-ai#256 ·
Maintainers usually reply within 1 day
-
bug priority-medium to-agent
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ONLYOFFICE/DocumentServer#3917 ·