Emits websockets-pubsub on the parent containers
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 28/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- backend
Research direction
Start by comparing node-solid-ws/index.js with lib/create-server.js at line 103, focusing on how parent-container changes are handled when entries are added or removed. Done means changes to parent containers emit the expected websockets-pubsub notification, including cases the request URL alone cannot identify.
Written by the indexing model from the issue text.
Description
When a parent container changes, it's not picked up by https://github.com/solid/node-solid-ws/blob/master/index.js because that code only looks at the URL of the request and has no way of knowing whether any parent containers were created in the process. We probably need to call https://github.com/solid/node-solid-server/blob/0542fa24b240936eac3a8051f9ca01a8e93e1912/lib/create-server.js#L103 explicitly when adding/removing entries in (parent) containers
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nodeSolidServer/node-solid-server
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
nodeSolidServer/node-solid-server#1848 · 2 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nodeSolidServer/node-solid-server#1841 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nodeSolidServer/node-solid-server#1147 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
nodeSolidServer/node-solid-server#1867 ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
nodeSolidServer/node-solid-server#1853 ·
All issues in nodeSolidServer/node-solid-server
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
Mintplex-Labs/anything-llm#6490 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
[quality] workflow-scripts guard reads test:unit:coverage as skipping the unit suite, blocking #632 Openagent/quality hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
area-clientside-dartpad
Difficulty 2/5 1-3 hours Newbie friendliness 62/100