chore(test): vite rebuild fixture output breaks the next `pnpm build`
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript, vite
- Domain
- build-system
Research direction
Start in test/vite/rebuild.test.ts, where the fixture output in test/vite/rebuild-fixture/dist is removed only before the run — add cleanup after it, or alternatively add a test/**/dist entry to the exclude in the root tsconfig.json. Verify by running pnpm test:rolldown (or test:rollup) followed by pnpm build and confirming the TS4094 error from rolldown-plugin-dts no longer appears without manually deleting the folder.
Written by the indexing model from the issue text.
Description
After running pnpm test:rolldown (or test:rollup), test/vite/rebuild.test.ts leaves its build output in test/vite/rebuild-fixture/dist (gitignored). The next pnpm build then fails in rolldown-plugin-dts because tsgo picks up dist/server/_libs/h3+rou3+srvx.mjs from that folder and reports TS4094: Property '#body' of exported anonymous class type may not be private or protected (allowJs is on and the root tsconfig.json does not exclude it). Deleting the folder makes the build pass again.
Possible fixes: clean up dist at the end of the test (it is only removed before the run today), and/or exclude test/**/dist in tsconfig.json.
Reported with AI assistance.
- Dominant language
- TypeScript
- Stars
- 11.3k
- Forks
- 914
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 81
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nitrojs/nitro
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Github Pages workflow is outdatedMay be free again A pull request for this issue was closed without being merged. Openpending triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nitrojs/nitro#4682 · 1 comment ·
Maintainers usually reply within 1 day
-
externals: absolute import of a traced package's `"."` export is rewritten to `pkg/` (ERR_PACKAGE_PATH_NOT_EXPORTED)Possibly taken @hungateJoseph claimed this 9 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nitrojs/nitro#4555 · 5 comments ·
Maintainers usually reply within 1 day
-
static: Accept-Encoding q-values silently drop compression when client includes weightsPossibly taken @MFA-G claimed this 77 days ago. Openv2 v3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
kind/chore priority/must
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sidereal-io/sidereal#380 ·
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
opfab/operatorfabric-core#10653 ·
Maintainers usually reply within 1 day
-
backend bug size:sm
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
chrisbenincasa/tunarr#2237 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 Half a day Newbie friendliness 69/100
Lam30ne/regulate-app#39 ·