fix own property lookup for primitive values

Open
  • Is something wrong?
#250 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c, javascript
Domain
compilers

Research direction

Start by reproducing the primitive-value property lookups shown in the issue and read test262's built-ins/Symbol/prototype/description/is-not-own-property.js. Compare njs's results with the test262 expectation; done means the lookup behavior conforms to that test for primitive values.

Written by the indexing model from the issue text.

Description

bug njs test262 
>> Object.getOwnPropertyDescriptor(1, 'toFixed')
{
 value: [Function: native],
 writable: true,
 enumerable: false,
 configurable: true
}
>> 1..hasOwnProperty('toFixed')
true

test262: built-ins/Symbol/prototype/description/is-not-own-property.js

Dominant language
C
Stars
1.6k
Forks
245
Avg merge
2d 5h
Merged PRs (30d)
6

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nginx/njs

All issues in nginx/njs

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.