[Bug]: F-29 The mime icon redirect is fetched again for every file list
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- php
- Domain
- backend, performance
Research direction
Start in core/Controller/PreviewController.php at getMimeIconUrl() and inspect the existing unit test mentioned in the report. Reproduce the Files app request behavior or inspect the browser trace, then verify that the mime icon redirect is publicly cacheable for a day and that the versioned target still supports theme changes.
Written by the indexing model from the issue text.
Description
⚠️ This issue respects the following points: ⚠️
- This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
- This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
- I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
- I agree to follow Nextcloud's Code of Conduct.
- I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description
F-29 · The mime icon redirect is fetched again for every file list
| Severity | Performance (one PHP request per mime type and page load) |
| Component | core/Controller/PreviewController.php::getMimeIconUrl() |
| Affects | 35.0.1 |
| Verified | Unit test; observed as 303 … no-cache in the browser trace of the Files app |
/core/mimeicon?mime=… answers with a redirect to the static icon, with the default
Cache-Control: no-cache, no-store. Browsers ask PHP again on every page. The redirect now allows
caching for a day (public; the target URL is versioned, so theme changes still show up).
Steps to reproduce
see the top
Expected behavior
see the top
Nextcloud Server version
35
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
No response
- Dominant language
- PHP
- Stars
- 37k
- Forks
- 5.3k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 702
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nextcloud/server
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
0. Needs triage 35-feedback bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
0. Needs triage 35-feedback bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in nextcloud/server
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
thephpleague/commonmark#1159 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
awslabs/aidlc-workflows#1879 ·
Maintainers usually reply within 1 day
-
[Bug] The PHP file that lists DNS records truncates records to 12 characters?Possibly taken @sahsanu claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
hestiacp/hestiacp#5769 · 2 comments ·
Maintainers usually reply within 1 day
-
bug customer-reported
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MagnaCapax/PMSS#1011 ·
Maintainers usually reply within 5 days
-
Talk Review
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
socallinuxexpo/scale-drupal#351 ·